Fix editor-only visibility for lights #62335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update visibility again for editor-only lights if owner changes. Fixes godotengine#26399, supersedes godotengine#52327
akien-mga
reviewed
Jun 23, 2022
| @@ -176,6 +176,11 @@ Ref<Texture2D> Light3D::get_projector() const { | |||
| return projector; | |||
| } | |||
|
|
|||
| void Light3D::owner_changed_notify() { | |||
| // For cases where owner changes _after_ entering tree (as example, editor editing). | |||
There was a problem hiding this comment.
Sounds like a comment that should go in node.cpp/h to clarify what this core API is for.
There was a problem hiding this comment.
I could add one there (though the function is quite self explanatory by name), but this comment is meant specifically for these nodes, because the editor-only lights need to check the owner to verify they are in the right scene and hence see that it must be enabled or disabled.
JFonS
approved these changes
Jun 23, 2022
|
Thanks! |
akien-mga
added
the
cherrypick:3.x
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26399, supersedes #52327