Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x]Add a second, deferred visibility check for lights. #52328

Closed
wants to merge 1 commit into from

Conversation

JestemStefan
Copy link
Contributor

@JestemStefan JestemStefan commented Sep 1, 2021

The deferred visibility check will see the correct value for
get_owner(), while the first might not.

Fixes #26399 for 3.x.
3.x version of #52327

I checked and original fix still works so I'm making a PR. Sorry!

The deferred visibility check will see the correct value for
get_owner(), while the first might not.

Fixes godotengine#26399
@JestemStefan JestemStefan requested review from a team as code owners September 1, 2021 21:23
@JestemStefan JestemStefan changed the title Add a second, deferred visibility check for lights. [3.x]Add a second, deferred visibility check for lights. Sep 1, 2021
@Calinou Calinou added this to the 3.4 milestone Sep 1, 2021
@akien-mga akien-mga modified the milestones: 3.4, 3.5 Nov 8, 2021
@akien-mga akien-mga force-pushed the 3.x branch 2 times, most recently from 71cb8d3 to c58391c Compare January 6, 2022 22:40
@akien-mga
Copy link
Member

Superseded by #62335, which could likely be cherry-picked for 3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants