Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add outline to polygon 2D indices, to make it more visible #60094

Closed
wants to merge 1 commit into from
Closed

Add outline to polygon 2D indices, to make it more visible #60094

wants to merge 1 commit into from

Conversation

eruhlinteractive
Copy link
Contributor

@eruhlinteractive eruhlinteractive commented Apr 10, 2022 •
edited by Chaosus
Loading

@eruhlinteractive eruhlinteractive requested a review from a team as a code owner April 10, 2022 05:24
@Chaosus Chaosus changed the title Added outline to polygon 2d indices per #38009 Add outline to polygon 2D indices, to make it more visible Apr 10, 2022
@Chaosus Chaosus added this to the 4.0 milestone Apr 10, 2022
@Calinou
Copy link
Member

Calinou commented Apr 10, 2022 •
edited
Loading

That outline size looks pretty massive and may cause stuttering the first time characters are drawn (especially on hiDPI displays). Can't we just use a standard EDSCALE outline size (or perhaps 2 * EDSCALE) as done in other places in the editor?

See #59119 for an example of this.

@eruhlinteractive
Copy link
Contributor Author

eruhlinteractive commented Apr 10, 2022 •
edited
Loading

Of course- Does this look better? Outline size is set using 2 * EDSCALE. If so I will amend the commit
image

@Calinou
Copy link
Member

Calinou commented Apr 10, 2022 •
edited
Loading

Of course- Does this look better? Outline size is set using 2 * EDSCALE. If so I will amend the commit

Try using the bold editor font for the label, as outlines generally don't look good on text with regular (non-bold) weight. This is something I should have done in #59119, but forgot.

@eruhlinteractive
Copy link
Contributor Author

image
This is how it looks using the bold editor font. Should the outline be made any thicker?

@akien-mga akien-mga requested a review from Calinou April 11, 2022 21:26
@clayjohn clayjohn mentioned this pull request Oct 3, 2022
Closed
@Cretezy Cretezy mentioned this pull request Jan 4, 2023
Merged
@Cretezy
Copy link
Contributor

Cretezy commented Jan 4, 2023 •
edited
Loading

Hello, it seems this PR is outdated. To draw outlines, you must now use draw_string_outline.

I've taking the liberty of opening an alternative PR here: #70902. I've also used the same approach as in #36530, which has already been merged.

Feel free to update this PR with the code, and I can close it.

@akien-mga
Copy link
Member

Superseded by #70902.

@akien-mga akien-mga closed this Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
archived enhancement topic:editor topic:2d usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

2D Polygon indices are barely visible on bright background
5 participants
@eruhlinteractive @Calinou @Cretezy @akien-mga @Chaosus