Add outline to ruler tool

[KoBeWi]

Not sure about this tbh, but at least it solves an issue. It seriously triggered me.

Before:

After:

Probably resolves #33523 and resolves #42988

[Calinou]

Try adding a 1-pixel offset on each side of the backdrop so the text doesn't "touch" any of its edges. This may look a bit better. Other than that, the feature looks good to me 🙂

[YeldhamDev]

Wouldn't be better for the text to just have a stronger outline?

[KoBeWi]

Ok, increased the rect by 1 pixel

but I can't push changes right now for some reason.

[marcotmotta]

I like the feature. Also good code formatting.

[YeldhamDev]

Gonna sound like a broken record, but would be nice to have it be an outline instead. Would be subtler, and be consistent with #42995.

[groud]

Ah damn, sorry I didn't see your comment. Indeed, a simple oultine might be better IMHO.
It seems quite easy to implement too, so guess it makes sense.

[KoBeWi]

Is this alright?

I copied the code from #42995.

[groud]

Could you maybe try with a slightly larger outline? It seems that in some cases the outline ends up not rendered.

[Calinou]

If you use an outline, consider using the editor's bold font so that the "white" part of the font is more visible. Right now, the text isn't easy to read.

[KoBeWi]

It already uses the bold font.

[groud]

It's weird that the outline get such a a weird rendering. But anyway, I believe it's legible enough so that's fine to me.

[rsubtil]

I noticed this happening with the zoom label too some time ago. Apparently, the outline is "desync-ed" and is slightly smaller than the original text:

(top is the zoom label, the bottom is a label from a scene with the same font and outline settings)

I have no clue why this is happening, I inspected some variables in the debugger, and the outline's size matched the font's size.

However, with the new font rewrite, this was fixed, by changing to this:

zoom_reset->add_theme_constant_override("outline_size", 1);
zoom_reset->add_theme_color_override("font_outline_modulate", Color(0, 0, 0));

[KoBeWi]

Rebased. The new font changes made the code even bigger :/ but at least it looks much better now

[akien-mga]

Thanks!

[GTcreyon]

Any chance of this being present in the next version? Perhaps I'm missing something, but it's definitely not here right now.

[KoBeWi]

This was never backported to 3.x, because it uses some functionality that doesn't exist there. It would need a separate PR.