Fix physics 2D/3D contact points rendering #55486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Physics internal process was removed by mistake, it's needed for contact points to be updated each frame. Fixed some multimesh parameters to allow 3D contact points to be drawn, although it's still not working well in 3D as only some of the contact points are drawn, and some of them keep being drawn when the number of visible instances drops to 0 instead of hiding them all.
akien-mga
approved these changes
Nov 30, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Physics internal process was removed by mistake, it's needed for contact points to be updated each frame.
Fixes the 4.x specific part of #53486 (contact points not rendering at all in 2D).
Fixes a part of #45862 (contact points not rendering at all in 3D).
Fixed some multimesh parameters to allow 3D contact points to be drawn, although it's still not working well in 3D because of an issue with multimesh rendering. Only some of the visible instances are drawn, and some of them keep being drawn when the number of visible instances drops to 0 instead of hiding them all.
Current state in 3D:
Not all contact points appear, and they don't disappear as they should at the end.