Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed closed path ROTATION_MODE_ORIENTED #55108

Closed
wants to merge 2 commits into from

Conversation

Yxure
Copy link

@Yxure Yxure commented Nov 18, 2021

Paralell rotation frame does not guarantee that the rotation at the beginning of the curve is equal to that at the end of the curve. This caused that in PathFollows3D with ROTATION_MODE_ORIENTED the rotation changed suddenly at the end of the loop. Added checkbox option to smooth the curve tilt.

_.Test.tscn.-.RotationBezier.-.Godot.Engine.2021-11-19.00-03-15.mp4

Fixes #27137 and part of #47445

@YeldhamDev YeldhamDev added this to the 4.0 milestone Nov 19, 2021
@Yxure Yxure marked this pull request as draft November 20, 2021 16:15
@Yxure Yxure marked this pull request as ready for review November 20, 2021 16:16
@Calinou
Copy link
Member

Calinou commented Jan 25, 2022

I'm not sure if the auto_tilts property name effectively conveys what it's supposed to do.

Also, does this need to be made optional? Is there a reason as to why someone would want to leave this disabled?

@Yxure
Copy link
Author

Yxure commented Jan 25, 2022

I got the idea from this paper. Basically it says that you can use this technique to rotate several times around the path. But thinking about it now, it's not very common and it shouldn't be too difficult to code it yourself. I will remove the auto tilts option.

@Yxure Yxure closed this Jan 25, 2022
@Calinou Calinou removed this from the 4.0 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path (3D) seems to make a wrong rotation
3 participants