Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement inspector property array for PopupMenu and MenuButton #54533

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

rafallus
Copy link
Contributor

@rafallus rafallus commented Nov 3, 2021

(Edited)
Allows to add items to PopupMenu and MenuButton directly in the inspector just as #54342 did for ItemList

@rafallus rafallus requested review from a team as code owners November 3, 2021 02:57
@Chaosus Chaosus added this to the 4.0 milestone Nov 3, 2021
@akien-mga
Copy link
Member

Could you give more details on what it is that this PR implements exactly? Is it related to a proposal or bug report, or other PRs that did similar changes? What does it look like?

@YuriSizov
Copy link
Contributor

Probably a part of #52463, from this closed issue #54522 (comment)

scene/gui/menu_button.cpp Outdated Show resolved Hide resolved
Copy link
Member

@groud groud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit f00ba79 into godotengine:master Nov 3, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants