Remove ItemList editor and replace it by a property array #54342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 28, 2021
akien-mga
approved these changes
Oct 28, 2021
groud
force-pushed
the
remove_item_list_editor
branch
from
0b85234 to
a51f922
Compare
|
Thanks! |
This was referenced Oct 28, 2021
aaronfranke
reviewed
Dec 6, 2021
| @@ -387,6 +381,9 @@ | |||
| <member name="icon_scale" type="float" setter="set_icon_scale" getter="get_icon_scale" default="1.0"> | |||
| The scale of icon applied after [member fixed_icon_size] and transposing takes effect. | |||
| </member> | |||
| <member name="items_count" type="int" setter="set_item_count" getter="get_item_count" default="0"> | |||
There was a problem hiding this comment.
This should likely be item_count for the sake of sounding natural to English speakers.
There was a problem hiding this comment.
Came here to say the same, although it's just a nitpick. It's consistent with the method names, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have the new property array in the inspector, make use of it (723 lines deleted, yay! 🥳 )
Peek.28-10-2021.09-49.mp4
This changes the ItemList properties, but it keeps the backward compatibility by importing the old "items" property anyway.
I also made a small change in ClassDB so that arrays count get stored by default. This is the first time we use the
add_property_array_count()function so I did not see the mistake before.Bugsquad edit: