[3.x] Fix RichTextLabel underline appearance when inside fill tag
#54296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, the lines does not end correctly if the RichTextLabel has content margin, I'll try to figure it out Update: Actually, done before tomorrow 🎉 |
timothyqiu
force-pushed
the
rtl-fill-underline
branch
from
689938a to
23c64fc
Compare
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3 to
c58391c
Compare
akien-mga
approved these changes
Jan 7, 2022
|
Thanks! |
|
Cherry-picked for 3.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32779
Fixes wrong appearance of underline, strikethrough, and url tags when used inside
[fill]by growing the underline horizontally with the amount introduced by the fill tag (align_spacing).The diff looks messy because I merged the drawing code of underline and strikethrough. The two blocks of code were basically the same except the Y position of the line.