Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline in u and url tags in RichTextLabel don´t cover extra spacing while fill tag is enabled #32779

Closed
Tracked by #39144
Bethleem opened this issue Oct 12, 2019 · 4 comments

Comments

@Bethleem
Copy link

Godot version: 3.1.1-stable_win32

OS/device including version: Windows 7/PC

Issue description: In RichTextLabel, when you have text between [fill] [/fill] tags, it sometimes adds extra spacing for the line to match the right edge. Well, this extra spacing is unkwon for [u] and [url] tags, that not put the underline under it and creates a ugly gap.

Steps to reproduce:
-Create a Rich text label.
-Add some text like "[Fill]Enough text to fill [u]the line and reach the [/u]right limit, so extra spacing may be added and NO UNDERLINED[/fill]"
-Enjoy the bug!

Minimal reproduction project:
Bbcode text in the example is: [fill]\t Se cree que [u]los primeros pobladores[/u][/fill]" and the output (see the not underlined gap between words "los" and "primeros"
bug

@KoBeWi
Copy link
Member

KoBeWi commented Nov 17, 2020

Still valid in 3.2.3

@bruvzg
Copy link
Member

bruvzg commented Jan 25, 2021

For the reference, it's fixed in master:
Screenshot 2021-01-25 at 09 56 05

@KoBeWi KoBeWi added this to the 3.2 milestone Jan 25, 2021
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Mar 17, 2021
@akien-mga
Copy link
Member

Seems still reproducible in 3.4 RC 1. Might be of interest to @timothyqiu 👀

@akien-mga
Copy link
Member

Fixed by #54296.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants