Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editor keyboard shortcut for Mono Build solution button #52633

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Add editor keyboard shortcut for Mono Build solution button #52633

merged 1 commit into from
Sep 14, 2021

Conversation

lewiji
Copy link
Contributor

@lewiji lewiji commented Sep 13, 2021

This is the 4.0 version of the following PR, now that Mono can compile again on master: #52595

This adds an editor shortcut named mono/build_solution and applies it to the editor's Build button if Mono is enabled. Default shortcut is Alt+B. It exposes the ED_GET_SHORTCUT macro to the GodotTools mono module via GodotTools.Internals.Globals.EditorShortcut to more generally allow editor shortcuts to be accessed by the mono C# project.

The minor difference between the 3.x and master changes is that the ShortCut Resource type on 3.x has been renamed to Shortcut on master.

@lewiji lewiji requested a review from a team as a code owner September 13, 2021 14:14
@YeldhamDev YeldhamDev added this to the 4.0 milestone Sep 13, 2021
lewiji
lewiji commented Sep 14, 2021
View reviewed changes
Copy link
Contributor Author

@lewiji lewiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I found the button. Since this is in the CS project, the syntax for the localisation is a bit different.

modules/mono/editor/GodotTools/GodotTools/GodotSharpEditor.cs Outdated Show resolved Hide resolved
@lewiji @akien-mga
Add editor keyboard shortcut for Mono Build solution button
913aa27 
Apply suggestions from code review

Merging @akien-mga's suggestion with the matching change to the CS project

Co-authored-by: Rémi Verschelde <[email protected]>
@akien-mga akien-mga merged commit de8d380 into godotengine:master Sep 14, 2021
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov mentioned this pull request Sep 14, 2021
Closed
@lewiji lewiji deleted the mono-build-solution-shortcut-4.0 branch September 15, 2021 12:21
@lewiji
Copy link
Contributor Author

lewiji commented Sep 15, 2021

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:dotnet topic:editor usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lewiji @akien-mga @YeldhamDev