Corrected "Save Scene" and "Save All Scenes" function when dir renamed #52573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:editor
cherrypick:3.3
cherrypick:3.x
… dir no longer exists
|
I have a complicated pr for moving directories to arbitrary locations that is distantly related to this pr. Not sure if you were interested in salvaging it. |
|
I can take a look at it later today if you want. |
akien-mga
approved these changes
Sep 29, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #52078
This problem seems to occur as the code checks whether the filename is defined but doesn't check if that filename/location actually exists. The problem can also be seen if you rename the directory outside of the editor for all scenes saved in that folder, regardless of if they have already been saved or not.
For "Save Scene", I added a DirAccess::exists check to see if the directory exists before attempting to save, and if it doesn't, prompting the user with an alert box. If the user clicks the ok on the alert, it triggers off a "Save Scene As" prompt.
For "Save All Scenes" this was not a viable solution to add, so I did the same DirAccess::exists check, and if any of the scenes failed it, prompted the user with a warning popup to say at least one scene was not able to be saved.