Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save all Scenes" gives unclear prompt for [unsaved](*) #54425

Closed
MatteoPiovanelli opened this issue Oct 30, 2021 · 5 comments · Fixed by #54721
Closed

"Save all Scenes" gives unclear prompt for [unsaved](*) #54425

MatteoPiovanelli opened this issue Oct 30, 2021 · 5 comments · Fixed by #54721

Comments

@MatteoPiovanelli
Copy link

Godot version

6b0b1a4

System information

Windows 10

Issue description

image
I would guess this has to do with #53705.
Outstanding changes to scenes that had been saved earlier are saved correctly.

This is different form Godot 3.3, where in the same conditions the prompt from the screenshot isn't shown, and the Editor, as far as I can tell, silently does nothing with "unsaved" scenes.

Steps to reproduce

Create a new project or open an existing one.
Create a new Scene.
Try to use the "Save all Scenes" functionality.
image

Outstanding changes to scenes that had been saved earlier are saved correctly.

Minimal reproduction project

Any project.

@MatteoPiovanelli
Copy link
Author

Possibly, the message in the popup should tell that the scenes need to first be saved by themselves. If I understand the code from the PR I linked, the only condition that would cause that warning to show is that there are one or more unsaved(*) scenes: were that the case, changing that text would probably make everything clear? Am I missing something

I would wish to see, for each "unsaved" scene, a "Save Scene As..." prompt.
image
I don't know how hard that would be.

@akien-mga
Copy link
Member

Related to #52573 and follow-up, CC @e8newallm @Calinou @KoBeWi

@e8newallm
Copy link
Contributor

The original reason for these changes was for issue #52078 where renaming a directory (Both in the editor and outside) that you've already saved a scene into will also cause saving to fail. For this issue at least, it's very important that the user is informed so they don't save and close and not have their scene saved properly.

It could potentially be fixed by simply skipping scenes that don't have a path already defined, however it could come across as inconsistent for some inability to save is skipped while others show an error (Granted the issue that triggered all this is an edge case that probably won't happen often). I don't think the proposed idea of popping up a "save as" box for each unsaved scene would work, as if you have multiple unsaved scenes it wouldn't be possible to indicate which scene is being saved when.

@MatteoPiovanelli
Copy link
Author

I guess a more verbose popup explaining that there wasn't really an error would be helpful already.

@golddotasksquestions
Copy link

golddotasksquestions commented Nov 7, 2021

I get this same popup since 3.4 when I try to run a scene, but have another scene open I never have saved yet. and it's incredibly annoying.

I often create new scenes to try stuff, scenes I usually don't want to save. But when I then run any other of my open but saved scenes I have to click away this pop up every time. It's super annoying.

Can we please have this revert to the behavior of 3.3.4?
Honestly I might switch back to 3.3.4 because of this. It just completely breaks my workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants