Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Minor visual improvements to the viewport rotation gizmo (again) #51324

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

AaronRecord
Copy link
Contributor

@AaronRecord AaronRecord commented Aug 6, 2021

This was requested here: #51284 (comment)
This can be merged independently of #51284.

Before:

2021-08-06_10-40-29.mp4

After:

2021-08-06_11-40-29.mp4

Apparently Blender's view rotation gizmo had gotten some visual improvements since when I had last updated it a couple of months ago (2.91). This make's Godot's view rotation gizmo more like Blender's:
image

master version here: #51326

@YuriSizov YuriSizov added this to the 3.4 milestone Aug 6, 2021
@AaronRecord AaronRecord force-pushed the show_view_rotation_dir-3.x branch 3 times, most recently from c4c314f to c05ede8 Compare August 6, 2021 16:50
@AaronRecord AaronRecord force-pushed the show_view_rotation_dir-3.x branch from c05ede8 to 9b3fc25 Compare August 6, 2021 17:39
@AaronRecord AaronRecord marked this pull request as ready for review August 6, 2021 17:41
@AaronRecord
Copy link
Contributor Author

AaronRecord commented Aug 6, 2021

I've made some more modifications to make the alpha decrease as the direction gets farther away, I think it looks pretty good (I've updated the original "After" video).
Here's what it looked like before:

2021-08-06_10-34-14.mp4

@AaronRecord AaronRecord force-pushed the show_view_rotation_dir-3.x branch from 9b3fc25 to a1e66e7 Compare August 6, 2021 17:58
@AaronRecord AaronRecord force-pushed the show_view_rotation_dir-3.x branch from a1e66e7 to 9613725 Compare August 6, 2021 20:38
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga akien-mga merged commit b4a8717 into godotengine:3.x Aug 7, 2021
@akien-mga
Copy link
Member

Thanks!

@AaronRecord AaronRecord deleted the show_view_rotation_dir-3.x branch August 7, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants