-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use antialiasing for the circles in the 3D editor rotation gizmo #51284
base: master
Are you sure you want to change the base?
Use antialiasing for the circles in the 3D editor rotation gizmo #51284
Conversation
This is a crude approach that relies on drawing a second translucent circle. While not as good as proper polygon antialiasing or 2D MSAA, it looks OK in practice.
This should be done in a separate PR. cc @LightningAA |
@floppyhammer Also apparently they've updated the blender rotation rotation gizmo since 2.91 which was what I had installed, I do like the new one even more. |
Could you add a before and after screenshot so it's easier to see the difference? Also, how much work would it take to implement proper antialiasing to |
I added comparison images to the OP.
I don't know, I haven't read about implementing antialiasing for circles specifically (unless they're polygon-based, but I'm not sure if Godot's are). |
I'm not sure that before image is completely accurate, the text color change was from #51250 (it doesn't really matter though, it still showcases the antialiasing). |
@LightningAA Yes they did. And the offset might be caused by display scaling. At v4.0.dev.custom_build [a4c8637], this occurs |
@floppyhammer I'd open a separate issue for that then to keep this PR on topic. |
Follow-up to #51250.
This is a crude approach that relies on drawing a second translucent circle. While not as good as proper polygon antialiasing or 2D MSAA, it looks OK in practice.
Preview
100% editor scale
200% editor scale