Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Illegible text in audio bus editor 3.x #50646

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Fix Illegible text in audio bus editor 3.x #50646

merged 1 commit into from
Jul 22, 2021

Conversation

SirQuartz
Copy link
Contributor

@SirQuartz SirQuartz commented Jul 20, 2021

This pull request fixes an issue where the text within the audio bus editor would be illegible. This version is tailored for 3.x.

These changes help significantly improve legibility.

See: #50593

Before, the tooltip text would become practically unreadable regardless of the theme being used when you started moving the scroll bar for the audio level of the buses. The label of the master audio bus would also be unreadable when using a light theme.

before_Trim.mp4

With the changes I've made it becomes significantly easier to parse and read what's on-screen when using any theme:

after_Trim.mp4

This pull request fixes an issue where the text within the audio bus editor would be illegible. This version is tailored for 3.x.
@akien-mga akien-mga merged commit 2ac292a into godotengine:3.x Jul 22, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Reverted with 2ae4748 to fix the regression #50890.

A fix for the original issue in 3.x would still be welcome, so we can work on a new PR that handles the original problem without the #50890 regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants