Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Illegible function prototype hint on 3.x #50890

Closed
timothyqiu opened this issue Jul 26, 2021 · 5 comments
Closed

Illegible function prototype hint on 3.x #50890

timothyqiu opened this issue Jul 26, 2021 · 5 comments
Labels
regression topic:editor usability
Milestone
3.4

Comments

@timothyqiu
Copy link
Member

Godot version

3.x (8ecb5d2)

System information

macOS 11.4

Issue description

3.x recently inverted the color scheme of tooltips. Function prototype hint of script editor now looks like this:

dark
light

It's hard to tell the tooltip from actual code. The return type in the screenshot looks like astint.

The tooltip on master has a larger padding, so not a problem on it.

Steps to reproduce

Open the script editor and try.

Minimal reproduction project

No response
@YuriSizov
Copy link
Contributor

Related to #50646.

@YuriSizov YuriSizov added this to the 3.4 milestone Jul 26, 2021
@akien-mga
Copy link
Member

CC @SirQuartz

@akien-mga
Copy link
Member

I'm about to build 3.4 beta 2 so I'll revert #50646 for now, we can then re-do it while making sure that this issue doesn't happen.

akien-mga added a commit that referenced this issue Jul 26, 2021
@akien-mga
Revert "Fix Illegible text in audio bus editor 3.x"
2ae4748 
This reverts commit d2cbf33.

Fixes #50890.
@akien-mga akien-mga mentioned this issue Jul 26, 2021
Merged
@akien-mga
Copy link
Member

Fixed by 2ae4748.

@SirQuartz
Copy link
Contributor

SirQuartz commented Jul 26, 2021 •
edited
Loading

Yeah, I think adding a shadow color for the tooltip would probably improve legibility a lot in the script editor.

sairam4123 pushed a commit to sairam4123/godot that referenced this issue Nov 10, 2021
@akien-mga @sairam4123
Revert "Fix Illegible text in audio bus editor 3.x"
e9176da 
This reverts commit d2cbf33.

Fixes godotengine#50890.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression topic:editor usability
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
4 participants
@timothyqiu @akien-mga @YuriSizov @SirQuartz