-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add signal to inform joint that body has exited tree #44703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouleyKetchoupp
suggested changes
Dec 30, 2020
Everything seems to work fine now! It should be good to go after the last little coding style fix. |
pouleyKetchoupp
approved these changes
Dec 31, 2020
Thanks! |
This was referenced Jan 9, 2021
This was referenced Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to inform a
Joint
that aPhysicsBody
attached to it has been removed. This PR connects thetree_exiting
signal from aPhysicsBody
attached to a configuredJoint
to provide this information and update theJoint
.Fixes #44510
Note: This also addresses:
Joint
that has had aPhysicsBody
freed without first disconnecting it from theJoint
; as described here.PhysicsBody
attached to aJoint
above it in the tree; as identified here.This PR includes raising the warning message in Bullet physics to an error; since this should now never occur.