Initialize class variables with default values in scene/ [1/2] #44630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qarmin
force-pushed
the
cppcheck_scene_1
branch
from
9719b05 to
e2e8f59
Compare
qarmin
force-pushed
the
cppcheck_scene_1
branch
from
e2e8f59 to
a741b0d
Compare
qarmin
force-pushed
the
cppcheck_scene_1
branch
from
a741b0d to
829448b
Compare
qarmin
force-pushed
the
cppcheck_scene_1
branch
from
829448b to
4668ecf
Compare
pouleyKetchoupp
approved these changes
Feb 2, 2021
akien-mga
reviewed
Feb 3, 2021
akien-mga
reviewed
Feb 3, 2021
akien-mga
reviewed
Feb 3, 2021
akien-mga
requested changes
Feb 3, 2021
There was a problem hiding this comment.
Looks great overall, thanks for the huge amount of work (I did the same for core and I know how tedious it is :D).
Found a couple bugs introduced by unwillingly changing the default value of some properties.
I initially commented about floats that should have .0 to make their type clear, but then stopped at some point as there's a ton of them. Would still be worth changing IMO, possibly by grepping the git show for (float|real_t) .* = .
| bool zero_y; | ||
| float cell_size = 1; | ||
| float radius = 10; | ||
| bool use_in_game = false; |
qarmin
force-pushed
the
cppcheck_scene_1
branch
from
4668ecf to
fbcb02c
Compare
qarmin
force-pushed
the
cppcheck_scene_1
branch
from
fbcb02c to
003bb8e
Compare
akien-mga
approved these changes
Feb 8, 2021
|
Thanks! Amazing work! |
This was referenced Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43636
Fixes in 4.0 #35877
Also moved initialization of data from constructors.