Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Complex Text Layouts] Adds missing Font::SPACING_* to the controls, align glyphs to pixel grid. #43981

Merged
merged 5 commits into from
Dec 7, 2020
Merged

[Complex Text Layouts] Adds missing Font::SPACING_* to the controls, align glyphs to pixel grid. #43981

merged 5 commits into from
Dec 7, 2020

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 30, 2020 •
edited
Loading

  • Fixes oversized editor control height (default editor spacing is negative) and control size changing when text is set.

Fixes #43966

  • Round glyph offsets and advances to make small size text sharper.

Fixes #43967

  • Fixes bitmap font leak.

Fixes #44002

  • Fixes missing text buffer init in ItemList::add_icon_item.

Fixes #44049

  • Some optimizations.

@bruvzg bruvzg added this to the 4.0 milestone Nov 30, 2020
@bruvzg bruvzg changed the title [Complex Text Layouts, WIP] Adds missing Font::SPACING_* to the controls. [Complex Text Layouts, WIP] Adds missing Font::SPACING_* to the controls, align glyphs to pixel grid. Dec 1, 2020
This was referenced Dec 2, 2020
Merged
Merged
Merged
@bruvzg bruvzg changed the title [Complex Text Layouts, WIP] Adds missing Font::SPACING_* to the controls, align glyphs to pixel grid. [Complex Text Layouts] Adds missing Font::SPACING_* to the controls, align glyphs to pixel grid. Dec 3, 2020
@bruvzg bruvzg marked this pull request as ready for review December 3, 2020 10:52
bruvzg added 4 commits December 6, 2020 20:30
@bruvzg
[Complex Text Layouts] Adds missing Font::SPACING_* to the Label, Lin…
a458e90 
…eEdit, TextEdit, TextLine and TextParagraph.

Fixes oversized editor control height (default editor spacing is negative) and control size changing when text is set.
@bruvzg
[Complex Text Layouts] Align glyph offsets and advances to the pixel …
c3cc9d8 
…grid.
@bruvzg
[Complex Text Layouts] Fix bitmap font memory leak.
384211a
@bruvzg
[Complex Text Layouts] Fix missing ItemList item text buffer init in …
a41f1c6 
…`add_icon_item`.
@akien-mga akien-mga merged commit 93e9c9c into godotengine:master Dec 7, 2020
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg mentioned this pull request Dec 11, 2020
Merged
@bruvzg bruvzg deleted the ctl_font_spacing branch December 14, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:gui
Projects
None yet
Milestone
4.0
2 participants
@bruvzg @akien-mga