Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix test_body_motion() sometimes failing to extracting collision information #43617

Open
wants to merge 6 commits into
base: 3.x
Choose a base branch
from
Open

[3.x] Fix test_body_motion() sometimes failing to extracting collision information #43617

wants to merge 6 commits into from
+1,139 −1,482

Conversation

madmiraal
Copy link
Contributor

3.2 version of #43616,

@madmiraal madmiraal added this to the 3.2 milestone Nov 17, 2020
@madmiraal madmiraal requested a review from a team as a code owner November 17, 2020 13:16
@madmiraal madmiraal mentioned this pull request Jan 6, 2021
Closed
@madmiraal
Copy link
Contributor Author

Rebased following merge of #42575.

@madmiraal
Refactor Godot Space2D and Space3D
3123577 
Removes duplicated code, unnecessary loops and unnecessary checks.
Adds missing checks and generates appropriate errors.
@madmiraal
Remove SPACE_PARAM_TEST_MOTION_MIN_CONTACT_DEPTH
fee10be 
To ensure that collision information is extracted and possible motion
is precise, the minimum contact depth must be 0. Therefore, there is no
need for this parameter.
@madmiraal
Remove minimum depth checks from Godot collision solvers
80509eb 
Ensures callback is always called.
Enables callback to control minimum depth checks.
@madmiraal
Do not treat zero rectangle or cube overlaps as collisions
b6af82d
@madmiraal
Refactor the Godot GJK EPA API to extract all GJK EPA result information
e91351c
@madmiraal
Make CollisionSolverSW::solve_distance return distance
e2553e5 
Generate appropriate error messages if it fails.
@madmiraal
Copy link
Contributor Author

Rebased following merge of #43924.

@madmiraal madmiraal requested a review from a team as a code owner March 12, 2021 12:26
Base automatically changed from 3.2 to 3.x March 16, 2021 11:11
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Mar 17, 2021
@akien-mga akien-mga modified the milestones: 3.3, 3.4 Mar 26, 2021
@akien-mga akien-mga changed the title [3.2] Fix test_body_motion() sometimes failing to extracting collision information [3.x] Fix test_body_motion() sometimes failing to extracting collision information Mar 26, 2021
@Chaosus Chaosus modified the milestones: 3.4, 3.5 Nov 8, 2021
@akien-mga akien-mga modified the milestones: 3.5, 3.x Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug topic:physics
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@madmiraal @Chaosus @akien-mga