[3.2] Fix multiple issues with one-way collisions #42575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmiraal
force-pushed
the
fix-one-way-collisions-3.2
branch
2 times, most recently
from
d7f0bf6
to
e63187f
Compare
capnm
reviewed
Oct 5, 2020
madmiraal
force-pushed
the
fix-one-way-collisions-3.2
branch
from
e63187f
to
bfa5036
Compare
|
I'm approving this for the same reasons explained here: #42574 (comment). (In this case, considering 3.2 is the production release, the part about testing a project which uses one-way heavily is much more important.) |
RandomShaper
approved these changes
Oct 17, 2020
madmiraal
force-pushed
the
fix-one-way-collisions-3.2
branch
from
bfa5036
to
a7d06a7
Compare
madmiraal
force-pushed
the
fix-one-way-collisions-3.2
branch
from
a7d06a7
to
780fc6b
Compare
|
Updated with the changes applied to #42574 i.e. both KinematicBody and RigidBody treat perpendicular contacts as pass through; and removed the change that was causing the bug. |
madmiraal
force-pushed
the
fix-one-way-collisions-3.2
branch
from
780fc6b
to
a327229
Compare
madmiraal
force-pushed
the
fix-one-way-collisions-3.2
branch
3 times, most recently
from
53b7e04
to
98604f1
Compare
|
Updated to properly fix the bugs identified by @Rhathe. |
madmiraal
force-pushed
the
fix-one-way-collisions-3.2
branch
from
98604f1
to
eb2d3fb
Compare
|
Updated to include the fix for #43266, identified by @AttackButton here. |
madmiraal
force-pushed
the
fix-one-way-collisions-3.2
branch
from
eb2d3fb
to
83f326c
Compare
|
Updated to ensure the work around applied in the previous update only applies during the unsticking phase. |
madmiraal
force-pushed
the
fix-one-way-collisions-3.2
branch
2 times, most recently
from
f66f43e
to
736e036
Compare
|
Updated to include the small refactor that removed some unneeded code. |
For RigidBodies, uses the collision normal determined by relative motion to determine whether or not a one-way collision has occurred. For KinematicBodies, performs additional checks to ensure a one-way collision has occurred, and averages the recovery step over all collision shapes. Co-authored-by: Sergej Gureev <[email protected]>
madmiraal
force-pushed
the
fix-one-way-collisions-3.2
branch
from
736e036
to
1061bb3
Compare
|
Updated to include the changes applied to #42574:
|
akien-mga
approved these changes
Jan 7, 2021
|
Thanks! |
This was referenced Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.2 version of #42574, i.e a salvage of #40645.