Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved MultiNodeEdit Blendshape Slider Support #43574

Closed
wants to merge 2 commits into from
Closed

Improved MultiNodeEdit Blendshape Slider Support #43574

wants to merge 2 commits into from

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Nov 15, 2020

Makes Blendshape Sliders in MultiNodeEdit visible in the Inspector even if not all MeshInstances have all the same Blendshapes.

Previously, if one of the selected MeshInstance Nodes was missing a single Blendshape all the Blendshape Sliders would disappear in the Inspector because MultiNodeEdit was expecting a perfect meta info match.

Fixes #35934

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor usability labels Nov 15, 2020
@Calinou Calinou added this to the 4.0 milestone Nov 15, 2020
editor/multi_node_edit.cpp Show resolved Hide resolved
Shows all available Blendshape Sliders in MultiEditMode even when some of the selected MeshInstance Nodes are missing one of the Blendshapes.
@smix8 smix8 requested a review from Calinou November 15, 2020 23:38
@fire fire requested a review from a team March 29, 2021 13:55
@smix8
Copy link
Contributor Author

smix8 commented Apr 15, 2021

@Calinou @fire
is this pr salvageable? I unintentionally deleted my old fork on a cleanup.

@akien-mga
Copy link
Member

It would need to be redone (be sure to make PRs from a dedicated branch instead of master to avoid having to do such cleanup). You can get the changes with https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/43574.patch and reapply them on a new branch.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 16, 2021
@smix8
Copy link
Contributor Author

smix8 commented Apr 16, 2021

Yep one lesson learned from this accident was "do the branches".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiNodeEdit hides Blendshape slider when Blendshape is not found on all selected MeshInstances
3 participants