Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiNodeEdit hides Blendshape slider when Blendshape is not found on all selected MeshInstances #35934

Closed
smix8 opened this issue Feb 5, 2020 · 1 comment

Comments

@smix8
Copy link
Contributor

smix8 commented Feb 5, 2020

Godot version:
3.2 stable.official

OS/device including version:
Windows 10 x64

Issue description:
MultiNodeEdit supports adjusting a blendshape on multiple selected Skeleton MeshInstance nodes at ones with a blendshape slider but the inspector only shows blendshape sliders or the blendshape category when they are found on ALL the selected MeshInstance nodes.

I think this might be an oversight / UI problem that effects the usability of the editor inspector when working with more complex 3d models with tons of blendshapes.

multinodedit_blendshapes

Found behavior:
When selecting multiple Meshinstance nodes the inspector only shows a blendshape slider when the blendshape name is found on ALL selected MeshInstances.

Expected behavior
The inspector should show a blendshape slider when a blendshape of the same name is found on ANY of the selected MeshInstances.

Problem with current behavior:
Adjusting the same blendshape name on multiple Meshinstances (e.g. many clothing meshes on a 3d character with multiple bodyshape morphs) by selecting one after another is tedious work in the editor. MultiNodeEdit solves this issue but the current requirement to deselect all the "wrong" MeshInstances for a certain blendshape slider to show up in the inspector works against this. Memorizing them all is nearly impossible on a complicated 3d model so the current manual workaround falls apart quickly.

Steps to reproduce:
Have multiple Skeleton MeshInstance nodes selected while only some of them share the same blendshapes.

Minimal reproduction project:
Project with a 3d skeleton model and 3 Meshinstances, 2 with the same blendshape.
MultiNodeEdit_Blendshape_Issue.zip

@akien-mga
Copy link
Member

As described in #47951 (comment), this is behaving as intended here, and would work the same for any kind of property not shared between all nodes in a multinode selection.

Changing this behavior should be done for all properties if approved from a design of view (for which a proposal should be opened on https://github.com/godotengine/godot-proposals).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants