Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Tabs not selected in RichTextLabel #42975

Closed
wants to merge 1 commit into from
Closed

Fixed: Tabs not selected in RichTextLabel #42975

wants to merge 1 commit into from

Conversation

torabshaikh
Copy link

@torabshaikh torabshaikh commented Oct 21, 2020

Fix #42656
Rich_Text

@Calinou Calinou added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:gui labels Oct 21, 2020
@Calinou Calinou added this to the 4.0 milestone Oct 21, 2020
@akien-mga akien-mga requested a review from Paulb23 October 22, 2020 08:02
akien-mga
akien-mga previously approved these changes Oct 31, 2020
@akien-mga akien-mga dismissed their stale review October 31, 2020 18:38

Too fast, missed something.

@akien-mga
Copy link
Member

akien-mga commented Oct 31, 2020

I initially approved but on second thought, I'm afraid that this might have unintended consequences on the use of cw further on, which is not only used for the display of this selection box.

See a bit below in the method where there's some logic which actually handles tabs specifically and increases cw again, so I think this PR might add bugs (I didn't test to confirm):
https://github.com/godotengine/godot/blob/de38ec06fc07f9a76622810536ce054bed5c4295/scene/gui/rich_text_label.cpp#L592-L595

@torabshaikh
Copy link
Author

torabshaikh commented Nov 19, 2020

@akien-mga Thanks for pointing out. Will it be alright if I add a different variable just to control the selection box? Please let me know if you can suggest anything else, I also want to declare a new variable just to show the box.

@Paulb23
Copy link
Member

Paulb23 commented Aug 30, 2021

Closing as the issue is fixed by #44487. However, feel free to open a PR for 3.x.

@Paulb23 Paulb23 closed this Aug 30, 2021
@Paulb23 Paulb23 added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs are not highlighted when selecting in RichTextLabel
4 participants