Tabs are not highlighted when selecting in RichTextLabel

[me2beats]

Godot version:

3.2.3

OS/device including version:

Windows

Issue description:

Tabs are not highlighted when selecting text in RichTextLabel.

Steps to reproduce:

1. create a RichTextLabel, set selection_enabled to True
2. Fill RichTextLabel with text that has tabs like this (you can just copy-paste it)

		hello		world

3. Select the text in this RichTextLabel using mouse

As you can see tabs areas are not highlighted
(but the text is selected with tabs - you сan verify this when Ctrl+C and Ctrl+V the selected text somewhere)

This is true for Output Log as well since it is a RichTextLabel so you could just

func _ready():
	print("		hello		world")

Expected result when selecting the text:

Minimal reproduction project:

[torabshaikh]

Hi @Calinou I want to contribute to the project and this looks like a good place to start from. Can you please guide me on this?

[Calinou]

@torabshaikh Thanks for your interest in contributing 🙂

The RichTextLabel node's code is at scene/gui/rich_text_label.cpp. Search for selection_bg (background color) and selection_fg (foreground color) to find the code that draws the selection.

See this page for compilation instructions. Remember to open the pull request against the master branch . This means that to test your changes, you need a GPU that fully supports Vulkan. If your GPU doesn't support Vulkan, work from the 3.2 branch, commit your changes, switch to the master branch and use the git cherry-pick command to pick the latest commit of the 3.2-based branch you've made.

[torabshaikh]

@Calinou Thanks for the info. I have set up the development environment and started debugging the code. I will submit a PR soon.

[bruvzg]

Fixed in master by #44487:

Screen.Recording.2021-01-25.at.11.19.27.mov