-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Move collision layer and mask into CollisionObject. #42771
Conversation
055e879
to
5e9648f
Compare
5e9648f
to
e1fcb08
Compare
Rebased following merge of 4287af5. |
e1fcb08
to
9e3d605
Compare
Rebased following merge of 015973d. |
9e3d605
to
e5b4a1c
Compare
Updated the documentation as suggested here. |
Rebased following e4addff. |
I wonder how this impacts compatibility for GDNative or other language bindings? Moving methods to a parent class should be transparent to GDScript but it does break the ABI, no? |
It doesn't, because the inherited methods have the same signature as before. This PR simply removes the duplication of defining (and in this case also declaring) them in their child classes. It resolves #26680: the current duplicate declaration prevents people using a pointer to the parent class to call the methods defined in the child classes. However, everyone can continue to call the individual methods in each child class as before. |
Thanks for the confirmation, sounds good to me then 👍 |
Thanks! |
3.2 version of #42770.