-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.2] Added Linux sanitizer with xvfb to github workspace #40994
Conversation
I have a problem with implementing properly working solution to get leaks without failing CI when finding thirdparty leak. When leak or usage of invalid memory happens, then this command return 1 which cause build failue
which is impossible to fix in Godot code and suppress. The solution for me is to disable exit code by adding e.g.
|
11a2212
to
2ce56bc
Compare
I also removed option to use specific binaries optimization e.g. for size, when using full debug symbols, because they compile too long. Also I must add workaround for importing Godot project, because |
94e8189
to
cb2d0a8
Compare
Thanks! |
Added in godotengine#40994 but without recent rebase, so they don't pass currently.
@qarmin This broke today, did you change the https://github.com/godotengine/godot/runs/1319773334?check_suite_focus=true |
Accidentally I pushed changes to 3.2 branch instead my own PR, and after that I probably reverted too much.
|
This PR allow CI to tests editor with virtual desktop with specific project
It:
Download project - https://github.com/qarmin/RegressionTestProject/tree/3.2 - which add to scene all nodes.
Godot should have "official" test project which could tests importing files(png, fbx, glb), executing basic functions etc.
Run editor - to import files which allows to run project later
Run project - with parameter which shows how long project will be executed(in second) - it runs only with renderer - GLES 3 - with master now this isn't possible due using Vulkan
Every single error is saved to log file, and after each command file is checked if contains specific text which is the result of an error.
There is a bug with running this specific project with GLES 2 inside xvfb-run, because at the end it shows
Segmentation fault(core dumped)
, so for now this step is missing.It is blocked by #37665 (seems that not always crash engine) and other issues with leaks