-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change in-editor documentation style to match online docs. #38917
Conversation
Yay for consistency! But what's up with the |
No idea, I have not changed it, it was always small for me. If it's intended to be small, it's probably HiDPI scaling issue (and wrong inheritance size might be the same issue). |
6d839b3
to
abb5713
Compare
Yep, it's using default font instead of docs, updated PR. |
Looks good to me 🙂 For extra consistency, the |
Update: Added cell border/background color support to the RichTextLabel (disable by default), and some table borders to the documentation (overview and properties, as the separate commit).
Changed it to en dash. |
abb5713
to
b8c289d
Compare
I like the idea, but from your screenshots on my display it's barely noticeable. |
b8c289d
to
f922016
Compare
f922016
to
f093944
Compare
scene/gui/rich_text_label.h
Outdated
|
||
ItemFrame() { | ||
type = ITEM_FRAME; | ||
parent_frame = nullptr; | ||
cell = false; | ||
parent_line = 0; | ||
odd_row_bg = Color(0, 0, 0, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move initialization to the declaration.
Edit: Fixed typo.
While the added RTL features look nice, I think they might warrant a dedicated PR as it's a core change, and it will conflict with #39248. |
f093944
to
1e3c02d
Compare
Done, RTL related changes are in #39587 |
Thanks! |
Some minor in-editor documentation style changes: