Preserve RichTextLabel's text while modyfing Custom Effects #38383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to #38284 (comment) the bug was fixed in 3.4, so this probably not needed anymore. Thanks for the contribution nevertheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling Text and BBCode's text in RichTextLabel is really complicated - one is dependent on the other (basically, top Text area in the Inspector can wok on its own, as long as you don't put anything into BBCode's text area - then it will replicate any text change to the top Text field) - that PR doesn't fix that, as it is bigger rework how that Control should work internally.
What that PR fixes, is - whenever there is a change to the Custom Effects array, then it'll preserve 'top' Text as it was entered before.
Fixes: #38284