Window minimize crash fix: #37327

[ThakeeNathees]

Fix: #37327

[bruvzg]

Should be INVALID_WINDOW_ID (which is -1) instead of -1.

Probably there's missing check for INVALID_WINDOW_ID somewhere in the window creation, AFAIK it should not be in the map.

[bruvzg]

Some missing checks I found:

godot/platform/windows/display_server_windows.cpp

Lines 498 to 500 in d2d359d

	WindowID window_id = _create_window(p_mode, p_flags, p_rect);
	WindowData &wd = windows[window_id];

_create_window can return -1

godot/platform/windows/display_server_windows.cpp

Lines 1788 to 1795 in d2d359d

	WindowID window_id = INVALID_WINDOW_ID;
	for (Map<WindowID, WindowData>::Element *E = windows.front(); E; E = E->next()) {
	if (E->get().hWnd == hWnd) {
	window_id = E->key();
	break;
	}
	}

Can potentially use -1 if window is not in the map (window is created but not added to the map, or removed from the map but still closing, not sure if any of this is possible).

[reduz]

Fix does not look correct, I have the feeling the problem is the creation flags for the minimized window..

[ThakeeNathees]

after the @bruvzg 's review I think that this is not a proper fix. I've just implemented some error fails for the crash and it worked. this might be a temporary fix.
@reduz

[HaSa1002]

You should catch it in the WndProc function with

if (window_id == INVALID_WINDOW_ID)
    return;

godot/platform/windows/display_server_windows.cpp

Line 1806 in d29514a

[marstaik]

@reduz @HaSa1002 I actually think this PR is correct. There are no windows creation flags for Vulkan, seen here: https://www.khronos.org/registry/vulkan/specs/1.2-extensions/man/html/VkWin32SurfaceCreateFlagsKHR.html

Also, according to here: https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VkWin32SurfaceCreateFlagsKHR

Note

Due to above restrictions, it is only possible to create a new swapchain on this platform with imageExtent being equal to the current size of the window.

The window size may become (0, 0) on this platform (e.g. when the window is minimized), and so a swapchain cannot be created until the size changes.

which the code does, it sees windows size being 0,0 and returns. But there is no code for handling a nullptr swapchain further up.

[KoBeWi]

The original issue is already fixed. Thanks for the contribution nonetheless.