Changed logic and optimized ObjectID in ObjectDB and Variant, removed…

[reduz]

Refactored how ObjectID works in ObjectDB, it is now very fast to obtain an object pointer from an ObjectID. Also, RefPtr was removed and the referencing logic for Refecence has been replicated inside Variant. This hugely simplifies the code and logic.

Finally, the functions to check if an object pointer is invalid were removed given they are dangerous and unfixable. Instead, Variant now contains an ObjectID together with the pointer, which ensures validity can be checked at all times.

Also fixes #32383

[reduz]

Had to do this because RefPtr no longer exists, should be fine I think

[reduz]

Doubt we will ever have more than 16 million object simultaneous instances, if we do we can always change this :P but giving priority (more bits) to the validator is usually better.

[RandomShaper]

Shouldn't this #ifdef stay?

[reduz]

No... stringify is not something that will affect performance anyway so it should be fine. The ifdefs were there because the reverse hash map in 3.x at some point was removed durin release build but then kept. Now it's gone so there is no longer a point.

[RandomShaper]

That's not the reason for my comment (the #endif ends anyway before the call to to_string()).

My point is that all other if (ScriptDebugger::get_singleton() [...] checks are inside an #ifdef DEBUG_ENABLED, because there's no point in non-debug builds. It's only for consistency.

[neikeq]

Why not Ref<Script>?

[reduz]

you can't, because Ref uses Reference, which inherits Object.. and since its a template, you can't forward declare it.

[akien-mga]

This fixes the mono build:

diff --git a/modules/mono/csharp_script.cpp b/modules/mono/csharp_script.cpp
index 43cdd19411..c722076fe2 100644
--- a/modules/mono/csharp_script.cpp
+++ b/modules/mono/csharp_script.cpp
@@ -854,7 +854,7 @@ void CSharpLanguage::reload_assemblies(bool p_soft_reload) {
 
 		while (script->instances.front()) {
 			Object *obj = script->instances.front()->get();
-			obj->set_script(RefPtr()); // Remove script and existing script instances (placeholder are not removed before domain reload)
+			obj->set_script(REF()); // Remove script and existing script instances (placeholder are not removed before domain reload)
 		}
 
 		script->_clear();
@@ -877,7 +877,7 @@ void CSharpLanguage::reload_assemblies(bool p_soft_reload) {
 
 				// Use a placeholder for now to avoid losing the state when saving a scene
 
-				obj->set_script(scr.get_ref_ptr());
+				obj->set_script(scr);
 
 				PlaceHolderScriptInstance *placeholder = scr->placeholder_instance_create(obj);
 				obj->set_script_instance(placeholder);
@@ -1003,7 +1003,7 @@ void CSharpLanguage::reload_assemblies(bool p_soft_reload) {
 				CRASH_COND(si != NULL);
 #endif
 				// Re-create script instance
-				obj->set_script(script.get_ref_ptr()); // will create the script instance as well
+				obj->set_script(script); // will create the script instance as well
 			}
 		}
 
diff --git a/modules/mono/mono_gd/gd_mono_internals.cpp b/modules/mono/mono_gd/gd_mono_internals.cpp
index 75aa77c7b0..74ffa90cb3 100644
--- a/modules/mono/mono_gd/gd_mono_internals.cpp
+++ b/modules/mono/mono_gd/gd_mono_internals.cpp
@@ -107,7 +107,7 @@ void tie_managed_to_unmanaged(MonoObject *managed, Object *unmanaged) {
 
 	ScriptInstance *si = CSharpInstance::create_for_managed_type(unmanaged, script.ptr(), gchandle);
 
-	unmanaged->set_script_and_instance(script.get_ref_ptr(), si);
+	unmanaged->set_script_and_instance(script, si);
 }
 
 void unhandled_exception(MonoException *p_exc) {

See above note on shadowing though, this warning spams the build a lot.

[akien-mga]

Thanks!