Check if bbcode is enable and filled before parsing and overwrite text property #36037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bbcode and overwrite text property When the RichTextLabel node gets duplicates the last property to be duplicate is CustomEffects wich calls the parse_bbcode method. Fix the parse_bbcode method to process only if the use_bbcode flagged and there is actual bbcode to be parsed, otherwise keep the current node text.
Calinou
changed the title
This was referenced May 29, 2020
|
Superseded by #39418. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the RichTextLabel node gets duplicates the last property to be duplicate is CustomEffects wich calls the parse_bbcode method. I've fix the parse_bbcode method to process only if the use_bbcode is flagged and there is actual bbcode to be parsed, otherwise keep the current node text.
Bugsquad edit: Fixes #35553