Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the script editor line length guideline by default #34763

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 2, 2020

Now that the GDScript style guide has an official recommendation, it makes sense to enable the line length guideline by default.

Now that the GDScript style guide has an official recommendation,
it makes sense to enable the line length guideline by default.
@akien-mga
Copy link
Member

I still feel 80 chars is way too low on today's high resolution 16:9 monitors (compared to the old 4:3 in 800x600 or less in use back when this convention was adopted for code), but let's give it a spin and see what people think of it :)

@akien-mga akien-mga merged commit 71d372a into godotengine:master Jan 2, 2020
@Calinou
Copy link
Member Author

Calinou commented Jan 2, 2020

@akien-mga We could move the default guideline position to 100 characters eventually. I didn't think about doing it right away, as the "soft limit" in the style guide is currently 80 characters.

@Calinou Calinou deleted the enable-line-length-guideline branch January 27, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants