Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkeletonDefinition Implementation #33684

Closed
wants to merge 1 commit into from

Conversation

marstaik
Copy link
Contributor

Allows Skeletons to share a common definition, as well as export skeletons for future use in other scenes.

@marstaik
Copy link
Contributor Author

Quick preview about what this SkeletonDefinition allows users to do:
https://f.staik.net/f/2cx.mp4

Allows Skeletons to share a common definition, as well as export
skeletons for future use
@fire
Copy link
Member

fire commented Dec 31, 2019

Imagine you want to export clothes when you don't have all the bones.

A master skeleton scene has every bone. So this skeleton structure should also have all the information to look up the name of the bones in the master skeleton.

The skin will do the remapping of the skeleton. The bone indices are indices to the skin which remap to indices in the skeleton.

Assumption: The new scene's skeleton has existing mesh instances-likes.

I propose that SkeletonDefinition will follow every assigned mesh and create such skins after the import of the SkeletonDefinition.

@fire
Copy link
Member

fire commented Jan 30, 2020

I've updated the pull request for the crash fix and to implement the above feature.

fire@2495689

Visually, it's importing skeleton defintions.

@akien-mga akien-mga requested a review from reduz January 31, 2020 11:03
@marstaik
Copy link
Contributor Author

Replaced partially by #36409

You can also now use scene instances of a skeleton to achieve the same effect, as meshes wont fail to bind by bone name anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants