Draw the outline as part of the Label font shadow #30168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #30165. This also affects the legacy font outlines for completeness' sake, but one isn't supposed to use both at the same time 🙂
Note that the font outline used by the shadow will have the same color as the main font outline. I tried overcoming this limitation by using a second FontDrawer instance dedicated to the shadow, but this caused the shadow's main font area to draw on top of the main font's outline (which looks bad). Therefore, I just made sure to use the main FontDrawer everywhere.
Preview
In order:
Before
After