Fix "Attach Node Script" dialog being off-center on first popup #28555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
Here's another PR that aims to fix this issue for all controls: #24907. |
|
Yeah, can confirm that it fixes this problem at least. |
|
Closing as superseded by #24907 which addresses the root of the problem. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that creating a script from within the Script editor (File > New Script...) would have its popup be centered correctly, so I looked at its code and saw that its call to
popup_centeredgave it size information:godot/editor/plugins/script_editor_plugin.cpp
Line 971 in dd2cd06
I just did the same for the Scene dock's popup call.
Fixes #14659