-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to edit Animation in Frames instead of Seconds. #22492
Conversation
Ability to edit Animation in Frames.
Oh yeah, thanks for adding this! Many users have been begging for this for while now :) How does the snapping work now for frame mode? The last image has a snapping of 3, but there are 0,5,7,12,14 etc highlighted above. Should this be snapping to every third frame? |
@fracteed Snapping can still be edited like you could in time mode, the last one just happens to have a snap of 3 because it converts whatever you snap choice was in time mode to frames in this case O.1 -> 3. As for the highlighting,i have no idea what that is supposed to indicate, it doesn't seem to be the snap setting but I'm unsure what it does indicate. It seems rather odd indeed. |
@dualmatrix so if you are in frame mode and enter a snapping value of 2, you would be snapping to every second frame? I guess the "(s)' text would have to update itself to a "(f)" when switching modes. |
@fracteed Yup that's how it works, and yeah that should probably be done, good catch. |
@avencherus That doesn't look good, I'll go over the code and make sure that doesn't happen anymore. Thanks for testing 👍 |
No problem. Looked like an interesting feature and was curious. X) |
I think this fixes #6149 too |
Superseded by 4203266. |
Added ability to edit Animation in Frames instead of Seconds. You can now choose which mode you want to edit in seconds/frames with a simple button:
You can also easily change at which framerate you want to edit the animation:
This does not alter any functionality to animations themselves and are contained wholy within the animation editor.
Currently there is still a need for a new icon for the newly introduced button (It will replace the all caps ENABLE_FRAME_MODE).
This is my first PR that's not just a bugfix, so some of the code might be a bit odd, any advice is appreciated!
This fixes #12165 and fixes #6149.