Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to edit Animation in Frames instead of Seconds. #22492

Closed
wants to merge 1 commit into from
Closed

Added ability to edit Animation in Frames instead of Seconds. #22492

wants to merge 1 commit into from

Conversation

Piet-G
Copy link
Contributor

@Piet-G Piet-G commented Sep 27, 2018

Added ability to edit Animation in Frames instead of Seconds. You can now choose which mode you want to edit in seconds/frames with a simple button:

1
2

You can also easily change at which framerate you want to edit the animation:

3

This does not alter any functionality to animations themselves and are contained wholy within the animation editor.

Currently there is still a need for a new icon for the newly introduced button (It will replace the all caps ENABLE_FRAME_MODE).

This is my first PR that's not just a bugfix, so some of the code might be a bit odd, any advice is appreciated!

This fixes #12165 and fixes #6149.

@Piet-G Piet-G changed the title Added ability to edit Animation in Frames. Added ability to edit Animation in Frames instead of Seconds. Sep 27, 2018
Ability to edit Animation in Frames.
@fracteed
Copy link

fracteed commented Sep 28, 2018

Oh yeah, thanks for adding this! Many users have been begging for this for while now :) How does the snapping work now for frame mode? The last image has a snapping of 3, but there are 0,5,7,12,14 etc highlighted above. Should this be snapping to every third frame?

@Piet-G
Copy link
Contributor Author

Piet-G commented Sep 28, 2018

@fracteed Snapping can still be edited like you could in time mode, the last one just happens to have a snap of 3 because it converts whatever you snap choice was in time mode to frames in this case O.1 -> 3.

As for the highlighting,i have no idea what that is supposed to indicate, it doesn't seem to be the snap setting but I'm unsure what it does indicate. It seems rather odd indeed.

@fracteed
Copy link

@dualmatrix so if you are in frame mode and enter a snapping value of 2, you would be snapping to every second frame? I guess the "(s)' text would have to update itself to a "(f)" when switching modes.

@Piet-G
Copy link
Contributor Author

Piet-G commented Sep 28, 2018

@fracteed Yup that's how it works, and yeah that should probably be done, good catch.

@ghost
Copy link

ghost commented Sep 28, 2018

Did a Win10 64-bit build and cherry picked this. I got this crash and stack trace when clicking on an AnimationPlayer from an existing project that had animation on it, or when making a new AnimationPlayer, the moment after creating a new animation and giving it a name.

cmd_2018-09-28_22-26-07

@Piet-G
Copy link
Contributor Author

Piet-G commented Sep 28, 2018

@avencherus That doesn't look good, I'll go over the code and make sure that doesn't happen anymore. Thanks for testing 👍

@ghost
Copy link

ghost commented Sep 28, 2018

No problem. Looked like an interesting feature and was curious. X)

@lupoDharkael
Copy link
Contributor

I think this fixes #6149 too

@akien-mga
Copy link
Member

Superseded by 4203266.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants