Fix performance for godot's interface #19871
Conversation
| @@ -942,6 +942,7 @@ void ItemList::_notification(int p_what) { | |||
| } | |||
| } | |||
|
|
|||
| minimum_size_changed(); | |||
There was a problem hiding this comment.
FYI, I'm adding this because ItemList don't update minimum size when adding/removing items and this will prevent a regression in the about dialog.
scene/gui/control.cpp
Outdated
| @@ -160,9 +160,16 @@ void Control::_update_minimum_size_cache() { | |||
| Size2 minsize = get_minimum_size(); | |||
| minsize.x = MAX(minsize.x, data.custom_minimum_size.x); | |||
| minsize.y = MAX(minsize.y, data.custom_minimum_size.y); | |||
|
|
|||
| bool size_changed; | |||
There was a problem hiding this comment.
Please initialize to false, don't rely on compilers to maybe mess it up ;)
guilhermefelipecgs
force-pushed
the
fix_performance_ui
branch
from
9b81cab to
b2e78e1
Compare
|
Actually this has been fixed here 005b69c by @reduz, "-Changed UI resizing code, gained huge amount of speed.", but this new improvements only exists on master and I unintentionally created a regression of his changes. But to be sure, I've tested this issue on stable and master branch with my patch and I can clearly see a big difference. After this patch, I can't notice any delays. I can move the 2D viewport with the tilemap selected and the performance remains the same as moving the screen without selecting it. |
|
I noticed the slowdown back then on a laptop, so if you have a powerful computer you may indeed not have seen the difference, so it needs to be tested on weaker computers (refer to the video I posted in #12391 to see the amplitude of the difference). |
|
@Zylann I saw your video and I was able to reproduce the problem in all stable branchs, the lag is there and it's very noticible on my machine! and after this pr fixed for me. You can try in an older machine and if you think this not fixed your issue, feel free to reopen it. |
|
I also did a simple "benchmark" test here, monitoring the cpu usage when working with TileMap and without it, and I can't see any noticeable difference, cpu usage is the same (with this pull request). |
|
@guilhermefelipecgs are you referring to the newer lag or the one I had back in #12391 ? (it sounds like they are two different occurences of lag getting worse) |
Make godot performance great again :)
Fix #19864, Fix #12391.
This fix isn't only for TileMap, it's for all control nodes. All interface now is very smooth when doing resizing.
This was a regression from changes that I made here #19334.