Fixes popup_centered_* methods, dialogs with wrong sizes and visual script editor #19334
+25
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermefelipecgs
force-pushed
the
fix_popup
branch
from
0c2dacd to
4210044
Compare
guilhermefelipecgs
changed the title
| @@ -452,10 +453,8 @@ void Control::_notification(int p_notification) { | |||
|
|
|||
| } break; | |||
| case NOTIFICATION_POST_ENTER_TREE: { | |||
There was a problem hiding this comment.
@reduz Can I remove NOTIFICATION_POST_ENTER_TREE? this is used only here so I don't know why do you create this. I can move this two lines above to NOTIFICATION_ENTER_TREE.
There was a problem hiding this comment.
There was a problem hiding this comment.
No, because computing size with out of tree controls should never happen, and children nodes receive that notification after the parent, so for cases like this it's needed.
There was a problem hiding this comment.
Ok, makes sense, thanks for explain. 👍
guilhermefelipecgs
force-pushed
the
fix_popup
branch
from
4210044 to
bdf4506
Compare
|
I discovered how to fix the last issue about "licence thirdparty". |
guilhermefelipecgs
force-pushed
the
fix_popup
branch
from
bdf4506 to
7a38827
Compare
This was referenced Jun 7, 2018
This was referenced Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16069, Fix #19292, Fix #19267, Fix #18940.
except for the licence thirdparty(Fixed now, the problem was caused by label autowrap with zero width. fix here);popup_centeredincorrectly positioned the first time.This pr also fix batch rename dialog with wrong size in the first time it appears.
Edit:
Fix this #19188 (comment) too.
Edit2:
Fix #19441.