Fix Alpha Border bugfix #12072
Fix Alpha Border bugfix #12072
Conversation
|
Please use tabs, |
ghost
added
|
@Noshyaar I'm sorry, this is my first pull request, so i didn't understand you clearly. What am i supposed to do? |
|
You can read about code style guideline here. Also, PR workflow here. Basically, use tabs for indentation (you're using spaces) and overwrite previous commit using Feel free to join Godot Discord or IRC Freenode (#godotengine-devel) so that the communication is more instantaneous. |
ComancheAk
force-pushed
the
fix-alpha-border-bugfix
branch
from
ed349b4 to
36f6c88
Compare
|
@Noshyaar done |
core/image.cpp
Outdated
| @@ -2473,7 +2473,8 @@ void Image::fix_alpha_edges() { | |||
|
|
|||
| if (rp[3] < alpha_threshold) | |||
| continue; | |||
|
|
|||
|
|
|||
| closest_dist=dist; | |||
There was a problem hiding this comment.
This line is still indented with spaces. Please use (five) tabs.
There was a problem hiding this comment.
Can you check it again? In Xcode IDE i have 5 tabs here
There was a problem hiding this comment.
Still the same. If it's changed, the comment will fold automatically.
core/image.cpp
Outdated
| @@ -2473,7 +2473,8 @@ void Image::fix_alpha_edges() { | |||
|
|
|||
| if (rp[3] < alpha_threshold) | |||
| continue; | |||
|
|
|||
There was a problem hiding this comment.
This line should be blank. No spaces or tabs.
ComancheAk
force-pushed
the
fix-alpha-border-bugfix
branch
from
36f6c88 to
82ac8db
Compare
|
Edit: changes look okay now. I'll keep this open for reviewers. |
ComancheAk
force-pushed
the
fix-alpha-border-bugfix
branch
2 times, most recently
from
a96a257 to
7bbae59
Compare
ComancheAk
force-pushed
the
fix-alpha-border-bugfix
branch
from
7bbae59 to
51597b6
Compare
|
@Noshyaar fixed with git add. Thank you! |
|
Ok, the changes LGTM and are pretty straightforward. Merging. |
|
Does this also fix #10632? |
This PR fixes Alpha Border fix, which was in this issue by art-kandy:
#12033
Fix Alpha Border in import now works well
