Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOF Far/Near Blur causes artifacts when glow is enabled #9756

Closed
sketchyfun opened this issue Jul 21, 2017 · 6 comments
Closed

DOF Far/Near Blur causes artifacts when glow is enabled #9756

sketchyfun opened this issue Jul 21, 2017 · 6 comments

Comments

@sketchyfun
Copy link
Contributor

sketchyfun commented Jul 21, 2017

Operating system or device - Godot version:
Windows 7 64bit
Godot 3.0 built from July 18th source (although I've seen this in earlier versions)
Running on a GeForce GTX 760

Issue description:
When you have both DOF Far Blur (or Near Blur) and Glow enabled, the glow texture becomes corrupted, as seen in the gif below:

image

Steps to reproduce:
Just enable DOF Far Blur and Glow at the same time

@sketchyfun sketchyfun changed the title DOF Far Blur causes artifacts when glow is enabled DOF Far/Near Blur causes artifacts when glow is enabled Jul 21, 2017
@kubecz3k kubecz3k added this to the 3.0 milestone Jul 23, 2017
@kubecz3k
Copy link
Contributor

kubecz3k commented Jul 23, 2017

for me on 4fe6b2a with those settings on, on linux and GTX1060 it looks better but also not good:
doof blur

@ghost
Copy link

ghost commented Jul 24, 2017

Just wondering, is glow_bicubic_upscale enabled? I've seen a similar issue with this option enabled.

@sketchyfun
Copy link
Contributor Author

@kubecz3k this is a separate issue I think. The values need capping otherwise it wraps around and causes the strange colours. If you change the glow mode to Additive, it works, it's just the other modes that are broken at the moment

@sketchyfun
Copy link
Contributor Author

@Noshyaar yes, but if I disable it, I don't get the glow effect at all (it used to work when I tested it many months ago)

@ghost
Copy link

ghost commented Jul 24, 2017

@kubecz3k That's #9106 I think.

@vnen
Copy link
Member

vnen commented Jul 26, 2017

Likely fixed by f5277e3. Let us know if it's not the case.

@vnen vnen closed this as completed Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants