Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glow post effect is broken for softlight and screen blend modes (regression from 5567e89) #9106

Closed
fracteed opened this issue Jun 9, 2017 · 3 comments

Comments

@fracteed
Copy link

fracteed commented Jun 9, 2017

Operating system or device - Godot version:
Windows 10 and Linux Mint

Godot 3.0

Issue description:
The glow post effect is giving an incorrect result for screen and softlight blend modes
glow_bug_comparison

Steps to reproduce:
turn on glow and use screen or softlight

Link to minimal example project:
glow_bug.zip

@himaghnam
Copy link

So that is the problem of glow! I thought it was light that was misbehaving!

@vnen vnen added this to the 3.0 milestone Jun 9, 2017
@Gibbz
Copy link

Gibbz commented Jun 17, 2017

same issue here. looks like the shader needs some clamping to preventing it going back into the negatives...

@ghost
Copy link

ghost commented Jul 24, 2017

Issue first occurs in 5567e89

@akien-mga akien-mga changed the title Glow post effect is broken for softlight and screen blend modes Glow post effect is broken for softlight and screen blend modes (regression from 5567e89) Jul 24, 2017
@reduz reduz closed this as completed in f5277e3 Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants