inst2dict does not turn classes inside classes to dict

[ivanskodje]

inst2dict does not turn classes inside classes to dict.

Here is an example of to_json() output;

{
	"description": "Some Desc",
	"id": 1337,
	"@path": "res://data/classes/project_class.gd",
	"tasks": [
		"[Reference:835]",
		"[Reference:836]",
		"[Reference:837]"
	],
	"@subpath": "",
	"name":"P Name"
}

I believe the classes (Reference:8XX) should also be converted to Dictionary for this to work as intended. :)

Currently; a workaround for this is to save the other classes as Dict, and use a set/get where you convert between class and dictionary. However I am sure inst2dict should also include subclasses.

Hope to see a fix implemented in the future :)

[Geequlim]

The functions inst2dict and dict2inst should handle the members of a script instance recursely.
And also they should could be used for all of script languages instead of GDScript only.

[Geequlim]

@bojidar-bg Any idea with this?

[bojidar-bg]

No, I never touched inst2dict/dict2inst code so far. I guess I might, if this issue sticks around 😆

[ghost]

First of all thank you for your report and sorry for the delay.

We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.

We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about it here?

For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.

Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.

Thanks in advance.

Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

[Xrayez]

I've stumbled upon the same issue when I needed to serialize data. I made a few attempts to modify inst2dict method using simple recursion. There should be definitely better ways to achieve this, but it seems to work (tested on 3 classes using inner instances of each other).

While trying to find a fix, I've also realized the same conversion should be done on properties that possibly have arrays of instances. For some reason I can't get it to work on arrays (most likely because of recursion hell).

[Geequlim]

You can try this implementation https://github.com/GodotExplorer/gdutils/blob/master/utils/InstanceManager.gd

[Rinkton]

I made a script, that fixes that bug and made inst2dict() and dict2inst() functions more convenient to use overall: Github repos

[AThousandShips]

For 4.x this method is now deprecated, so this is now only really relevant for 3.x:

• GDScript: Deprecate inst_to_dict() and dict_to_inst() functions #99121