Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKER] inst2dict and dict2inst related issues #33348

Open
3 of 6 tasks
Xrayez opened this issue Nov 4, 2019 · 3 comments
Open
3 of 6 tasks

[TRACKER] inst2dict and dict2inst related issues #33348

Xrayez opened this issue Nov 4, 2019 · 3 comments

Comments

@Xrayez
Copy link
Contributor

Xrayez commented Nov 4, 2019

Godot version:
3.2, 4.0+

Issue description:
There are quite a bunch of old issues present with inst2dict and dict2inst that it's worth to add a tracker for it. I'm currently working on some of them.

Issues

Preview Give feedback
  1. bug confirmed discussion topic:core topic:gdscript
  2. bug discussion topic:core
  3. bug confirmed discussion topic:core
  4. bug confirmed crash topic:gdscript
  5. bug topic:gdscript
  6. bug topic:gdscript

Other issues

Orphan issues or which need more discussion.

Fixes

I think it would be best if these fixes could be reviewed in order so that smaller fixes can be rebased on top of bigger ones more easily if deemed satisfactory:

They could as well be targeted for 4.0 but see for yourself.

CC @vnen @bojidar-bg.

@capnm
Copy link
Contributor

capnm commented Nov 5, 2019

[?] Fix the accessibility of the online API docs (might be a more general issue).

The https://docs.godotengine.org/en/latest/search.html?q=inst2dict query currently returns only a link to unusable c# hints instead of
https://docs.godotengine.org/en/latest/classes/[email protected]#class-gdscript-method-inst2dict

@nhold
Copy link
Contributor

nhold commented Nov 5, 2019

Can we add the following:

A class de-serialised with dict2inst fails if the class has moved it's path. A classes ability to be de-serialised should not be linked to it's path. I do get this might require a re-write to the entire gdscript language to force class names.

@Xrayez
Copy link
Contributor Author

Xrayez commented Nov 5, 2019

@capnm I think you could open an issue about this at godot-docs. It fails to search the class ref for some reason. I've stumbled upon this with other keywords if I recall correctly.

@nhold you could open a separate issue and/or proposal to discuss the best way to implement it first. But it feels like this could be solved relatively easy by writing global class name to dictionary along with script path. Edit: see possible implementation at #33360.

Anyways, added to Other issues section because they currently have no home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants