-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Blender ESCN exporter pages #10064
Conversation
is not maintained or supported in Godot 4.x. While not officially supported, the plugin may | ||
partially work for some Godot and Blender versions, particularly before Blender version 4.0. | ||
For complete docs on the Blender exporter, see the | ||
`previous version of this page <https://docs.godotengine.org/en/4.0/tutorials/assets_pipeline/escn_exporter/index.html>`__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should link to the last docs version that keeps the full set of pages. That will be either 3.6
, or maybe 4.0
or 4.1
if we only backport this PR as far as 4.2
.
Alternately, we could not link to the previous docs version at all, since that is implicitly supported by RTD version switching. I thought it would be good to leave an explicit link here, in case someone finds their way to this page or is still relying on the partial functionality of the addon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through the git blame of the various pages changed or removed in this PR, and besides unrelated naming or spelling changes, the last change was 4 years ago.
So this removed version has no relevant changes compared to whichever version continues to exist, either 4.0
/4.1
or 3.6
.
SCN for performance. | ||
The plugin `Godot Blender Exporter <https://github.com/godotengine/godot-blender-exporter>`__ | ||
is not maintained or supported in Godot 4.x. While not officially supported, the plugin may | ||
partially work for some Godot and Blender versions, particularly before Blender version 4.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't even want to suggest this much partial functionality, it's fine by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of doing a complete removal instead of deprecating. I'd also be in favor of just removing the escn_exporter index page
I'm fine with this, too. I thought leaving the stub redirect page would be good in case these changes are not cherrypicked all the way back to 4.0. |
The stub is (sadly) indeed a good idea right now as redirects don't 100% work - we have accumulated too many for ReadTheDocs to handle all of them (without paying for a high(er) tier). |
Thanks! |
Closes #8196.
Alternate or complement to #10067.
The addon Godot Blender Exporter has not been officially supported since Godot 4.x. While it partially works in some cases (see #8196 (comment)), since Blender version 4.0 it does not work at all. We should not be linking to an unsupported and unmaintained addon, much less using the official documentation as the documentation for an unmaintained addon!
I left a stub page which with a link to currently supported Blender exporting methods, as well as some information about the addon.