Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding settings for mix_rate, stereo and format for Mic Record Demo 4.0-dev #711

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Adding settings for mix_rate, stereo and format for Mic Record Demo 4.0-dev #711

merged 1 commit into from
Apr 3, 2022

Conversation

voylin
Copy link
Contributor

@voylin voylin commented Apr 2, 2022

Closes #470

@voylin
Copy link
Contributor Author

voylin commented Apr 2, 2022

I've been trying so many things now for this Pull Request and the checks keep failing. The message said do a rebase or amend but upon doing that, nothing changes ... Quite new to git and github so I'm probably doing something wrong here. But I can't tell what

@voylin
Copy link
Contributor Author

voylin commented Apr 2, 2022

If anyone knows what's going wrong here, please tell me as I have no idea and it's getting quite annoying

@aaronfranke
Copy link
Member

@voylin See these resources for how to use Git when contributing to Godot:

https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html

https://www.youtube.com/watch?v=0XKy8YpP5Ww

You can also fix CI checks by running the formatting script: file_format.sh. If you're on Windows you need WSL to run it.

@voylin
Copy link
Contributor Author

voylin commented Apr 2, 2022

@aaronfranke Thanks for the resources, I figured out that it was just because of some enters that it could not work. The video is especially helpful. Because of you I started using Gitkraken and I could also finally solve the "commit mess" and squash/rebase everything correctly. Thank you very much and sorry for the trouble I've been causing.

@voylin voylin changed the title Adding settings for mix_rate, stereo and format for Mic Record Demo Adding settings for mix_rate, stereo and format for Mic Record Demo 4.0-dev Apr 2, 2022
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this looks good.

audio/mic_record/README.md Outdated Show resolved Hide resolved
@aaronfranke aaronfranke added this to the 4.0 milestone Apr 3, 2022
small edit

Adding settings for mix_rate, stereo and format for Mic Record Demo

Adding settings for mix_rate, stereo and format for Mic Record Demo

small edit

Adding settings for mix_rate, stereo and format for Mic Record Demo

small edit

Adding settings for mix_rate, stereo and format for Mic Record Demo

small edit

Adding settings for mix_rate, stereo and format for Mic Record Demo

small edit

Adding settings for mix_rate, stereo and format for Mic Record Demo

small edit

Adding settings for mix_rate, stereo and format for Mic Record Demo

Fixing project settings
Small fixes

Vulkan to Vulkan Mobile,
Changed window size.
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aaronfranke aaronfranke merged commit 713dfd0 into godotengine:4.0-dev Apr 3, 2022
@voylin voylin deleted the PR_Request_Mic_Record_Demo branch April 3, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants