-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding settings for mix_rate, stereo and format for Mic Record Demo 4.0-dev #711
Adding settings for mix_rate, stereo and format for Mic Record Demo 4.0-dev #711
Conversation
I've been trying so many things now for this Pull Request and the checks keep failing. The message said do a rebase or amend but upon doing that, nothing changes ... Quite new to git and github so I'm probably doing something wrong here. But I can't tell what |
If anyone knows what's going wrong here, please tell me as I have no idea and it's getting quite annoying |
@voylin See these resources for how to use Git when contributing to Godot: https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html https://www.youtube.com/watch?v=0XKy8YpP5Ww You can also fix CI checks by running the formatting script: |
@aaronfranke Thanks for the resources, I figured out that it was just because of some enters that it could not work. The video is especially helpful. Because of you I started using Gitkraken and I could also finally solve the "commit mess" and squash/rebase everything correctly. Thank you very much and sorry for the trouble I've been causing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this looks good.
small edit Adding settings for mix_rate, stereo and format for Mic Record Demo Adding settings for mix_rate, stereo and format for Mic Record Demo small edit Adding settings for mix_rate, stereo and format for Mic Record Demo small edit Adding settings for mix_rate, stereo and format for Mic Record Demo small edit Adding settings for mix_rate, stereo and format for Mic Record Demo small edit Adding settings for mix_rate, stereo and format for Mic Record Demo small edit Adding settings for mix_rate, stereo and format for Mic Record Demo Fixing project settings Small fixes Vulkan to Vulkan Mobile, Changed window size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #470