Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3 methods from GDExtension class, following upstream #611

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Remove 3 methods from GDExtension class, following upstream #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35dede4
Remove 3 methods from GDExtension class, as they were removed upstream
Bromeon Feb 19, 2024
0db2d36
Run both minimal and full CIs against full+experimental codegen
Bromeon Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/full-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,14 +265,17 @@ jobs:

# Don't use latest Ubuntu (22.04) as it breaks lots of ecosystem compatibility.
# If ever moving to ubuntu-latest, need to manually install libtinfo5 for LLVM.
- name: linux

# Uses full+experimental codegen, so that compatibility breakage towards nightly is detected.
# If the experimental part causes problems, consider using only godot/codegen-full.
- name: linux-full
os: ubuntu-20.04
artifact-name: linux-nightly
artifact-name: linux-full-nightly
godot-binary: godot.linuxbsd.editor.dev.x86_64
rust-extra-args: --features godot/custom-godot
rust-extra-args: --features codegen-full-experimental

# Combines now a lot of features, but should be OK. lazy-function-tables doesn't work with experimental-threads.
- name: linux-double-full-lazy
- name: linux-double-lazy
os: ubuntu-20.04
artifact-name: linux-double-nightly
godot-binary: godot.linuxbsd.editor.dev.double.x86_64
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/minimal-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,11 @@ jobs:

# Linux

- name: linux
- name: linux-full
os: ubuntu-20.04
artifact-name: linux-nightly
godot-binary: godot.linuxbsd.editor.dev.x86_64
rust-extra-args: --features godot/custom-godot
rust-extra-args: --features codegen-full-experimental

- name: linux-features
os: ubuntu-20.04
Expand Down
5 changes: 5 additions & 0 deletions godot-codegen/src/special_cases/special_cases.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ pub fn is_class_method_deleted(class_name: &TyName, method: &JsonClassMethod, ct
//| ("Object", "to_string")
| ("Object", "get_instance_id")

// Removed in https://github.com/godotengine/godot/pull/88418, but they cannot reasonably be used before, either.
| ("GDExtension", "open_library")
| ("GDExtension", "initialize_library")
| ("GDExtension", "close_library")

// Thread APIs
| ("ResourceLoader", "load_threaded_get")
| ("ResourceLoader", "load_threaded_get_status")
Expand Down
Loading