Remove 3 methods from GDExtension class, following upstream
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following methods could not be properly used; it was thus decided to unbind them from the GDExtension API despite a breaking change: * GDExtension::open_library * GDExtension::initialize_library * GDExtension::close_library
Bromeon
added
quality-of-life
Bromeon
force-pushed
the
qol/adjust-removed-apis
branch
from
e988812 to
0db2d36
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-611 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following methods could not be properly used; the GDExtension team thus decided to unbind them from the API despite a breaking change:
GDExtension::open_libraryGDExtension::initialize_libraryGDExtension::close_libraryWe follow suit by removing them from our API as well, thus preventing loading errors in the method tables.
This PR also changes both minimal and full CI to use full codegen, to make these issues more obvious.
Related Godot PR: godotengine/godot#88418