fix(matchLabels): call BaseObject constructor with correct arguments #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1] changed BaseObject so that its properties were no longer a superset of the `options` BaseObject construtor argument (specifically removing the `name` property). That broke `.match()` and `.matchLabels()` which depended on that property. Fixes: #90 [1]:d083f93#diff-86b75ecfbd25aa771c8e9e0dff8eb00fL25
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 changed BaseObject so that its properties were no longer a
superset of the
optionsBaseObject construtor argument (specificallyremoving the
nameproperty). That broke.match()and.matchLabels()which depended on that property.Fixes: #90